From b86784fe3ab15ae3add69e08b20124661e5f13e2 Mon Sep 17 00:00:00 2001
From: admin <alec@bryanmail.net>
Date: Tue, 28 Jul 2026 21:27:13 -0700
Subject: [PATCH] =?UTF-8?q?fix:=20legacy=20container=20needs=20pg=5Fhba.co?=
 =?UTF-8?q?nf=20replication=20rule=20for=20pg=5Fbasebackup=20=E2=80=94=20a?=
 =?UTF-8?q?dded=20initdb.d=20hook=20script.=20Disposable=20test=20only,=20?=
 =?UTF-8?q?uses=20'trust'=20since=20this=20container=20is=20not=20auth-rep?=
 =?UTF-8?q?resentative.?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 postgresql/cutover/test/pgha-dryrun.yaml | 28 ++++++++++++++++++++++--
 1 file changed, 26 insertions(+), 2 deletions(-)

diff --git a/postgresql/cutover/test/pgha-dryrun.yaml b/postgresql/cutover/test/pgha-dryrun.yaml
index 008d49a..4b0bbd7 100644
--- a/postgresql/cutover/test/pgha-dryrun.yaml
+++ b/postgresql/cutover/test/pgha-dryrun.yaml
@@ -16,7 +16,8 @@
 # NOTE: command: blocks use $$(...) not $(...) — Compose's own variable
 # interpolation parses $( as an attempted ${VAR} reference and fails with
 # "invalid interpolation format" / "you may need to escape any $ with
-# another $". $$ escapes to a literal $ for the shell at runtime.
+# another $". $$ escapes to a literal $ for the shell at runtime. Same
+# reasoning applies to $$PGDATA below.
 #
 # NOTE: ETCD3_HOSTS not ETCD_HOSTS — confirmed against zalando/spilo
 # configure_spilo.py: PATRONI_DCS includes both "etcd" (legacy v2 API,
@@ -25,6 +26,20 @@
 # (v3.5.9) have the v2 API disabled by default, so ETCD_HOSTS causes
 # Patroni to hit /v2 endpoints that 404. ETCD3_HOSTS selects the correct
 # v3-API client.
+#
+# NOTE: "legacy" needs a pg_hba.conf rule permitting REPLICATION-type
+# connections, which is a distinct connection class from normal client
+# connections in Postgres. The vanilla postgres:17 image's default
+# pg_hba.conf allows normal client connections (pg_dumpall worked earlier)
+# but NOT replication connections, which pg_basebackup (used by Patroni's
+# CLONE_WITH_BASEBACKUP) requires. Fixed via a /docker-entrypoint-initdb.d/
+# hook script (the officially supported extension point, runs once right
+# after initdb, before the server's final restart) that appends a
+# permissive "trust" rule for replication connections. "trust" is
+# acceptable ONLY because this container is fully disposable and exists
+# solely to validate cutover mechanics, not auth. See the note
+# "ADR-0001 Addendum — pg_hba.conf replication prerequisite discovered in
+# dry run" for the real production prerequisite this exposes.
 # ─────────────────────────────────────────────────────────────────────────
 version: "3.6"
 
@@ -34,7 +49,16 @@ services:
   legacy:
     image: public.ecr.aws/docker/library/postgres:17
     hostname: db
-    command: [postgres]
+    entrypoint: ["/bin/sh", "-c"]
+    command:
+      - |
+        mkdir -p /docker-entrypoint-initdb.d
+        cat > /docker-entrypoint-initdb.d/zz-enable-replication.sh <<'EOF'
+        #!/bin/sh
+        echo "host replication all all trust" >> "$$PGDATA/pg_hba.conf"
+        EOF
+        chmod +x /docker-entrypoint-initdb.d/zz-enable-replication.sh
+        exec docker-entrypoint.sh postgres
     environment:
       POSTGRES_USER: PGadmin
       POSTGRES_PASSWORD_FILE: /run/secrets/postgresql_password